Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6314 Pass the error code instead of the retries count in the RUCSS strategy #6317

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Dec 11, 2023

Description

Pass the error code instead of the retries count, as the expected second parameter of increment_retries() is the error code value.

Fixes #6314

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No grooming for XS

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).

@remyperona remyperona requested a review from a team December 11, 2023 20:35
@remyperona remyperona self-assigned this Dec 11, 2023
@remyperona remyperona added module: remove unused css type: bug Indicates an unexpected problem or unintended behavior labels Dec 11, 2023
@MathieuLamiot
Copy link
Contributor

I don't think this would need QA @wp-media/qa-team?

@Tabrisrp, if you tested it locally I think it is enough.

@vmanthos
Copy link
Contributor

I don't think this would need QA

Agreed. 👍

@remyperona remyperona added this pull request to the merge queue Dec 13, 2023
Merged via the queue into develop with commit 2b2243e Dec 13, 2023
@remyperona remyperona deleted the fix/6314-incorrect-parameter branch December 13, 2023 14:31
@remyperona remyperona added this to the 3.15.7 milestone Dec 15, 2023
wordpressfan pushed a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: remove unused css type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parameter passed to the increment_retries
4 participants