-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6367 Add theme resolver for compatibility classes #6390
Conversation
@Tabrisrp Thanks for the PR. using the helper plugin and trying those steps 3 times, can see small improvement on the PR (instead of global time 54.80ms it is 52.71ms). However, can see UI regression in this scenario https://wpmediaqa.testrail.io/index.php?/tests/view/41471&group_by=cases:section_id&group_id=709&group_order=asc |
@Tabrisrp If I understand the old code correctly, the callback Now maybe, if we are in another theme and switching to Divi, the callback is not registered since the Divi compat is not loaded so nothing happens. If my understanding is correct, the issue is well described here: https://developer.wordpress.org/reference/hooks/switch_theme/ |
Tested with |
Nice! |
working fine now |
Description
Replace current instantiation of themes compatibility classes from loading them all, to only loading the one corresponding to the current theme (if it exists).
Fixes #6367
Type of change
Checklists
Generic development checklist
Test summary