Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/6471 remove treeshake param and provide logs of sent requests #6587

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Task/6471 remove treeshake param and provide logs of sent requests #6587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db779b
Removed treeshake parameter and inidicate start and end process on log
jeawhanlee Apr 24, 2024
a402098
Updated tests
jeawhanlee Apr 24, 2024
aee078d
phpcs fix
jeawhanlee Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inc/Engine/Common/JobManager/JobProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@ public function check_job_status( string $url, bool $is_mobile, string $optimiza
* @return void
*/
public function process_on_submit_jobs() {
$this->logger::debug( 'Start processing on submit jobs for adding jobs to queue.' );

/**
* Fires at the start of the process on submit jobs.
*
Expand Down Expand Up @@ -264,6 +266,7 @@ public function process_on_submit_jobs() {
);
}

$this->logger::debug( 'End processing on submit jobs for adding jobs to queue.' );
/**
* Fires at the end of the process pending jobs.
*
Expand All @@ -282,7 +285,6 @@ public function process_on_submit_jobs() {
*/
protected function send_api( string $url, bool $is_mobile, string $optimization_type ) {
$config = [
'treeshake' => 1,
'is_mobile' => $is_mobile,
'is_home' => Utils::is_home( $url ),
];
Expand Down
3 changes: 0 additions & 3 deletions tests/Fixtures/inc/Engine/Common/JobManager/APIHandler/APIClient/optimize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
'html' => 'some html',
'url' => 'http://example.com/path/to/style.css',
'options' => [
'treeshake' => 1,
'wpr_email' => '[email protected]',
'wpr_key' => 'SuperSecretRocketeerKey',
'rucss_safelist' => [ 'http://example.com/my/safe/css.css' ],
Expand Down Expand Up @@ -52,7 +51,6 @@
'html' => 'some html',
'url' => 'http://example.com/path/to/style.css',
'options' => [
'treeshake' => 1,
'wpr_email' => '[email protected]',
'wpr_key' => 'SuperSecretRocketeerKey',
'rucss_safelist' => [ 'http://example.com/my/safe/css.css' ],
Expand Down Expand Up @@ -93,7 +91,6 @@
'html' => 'some html',
'url' => 'http://example.com/path/to/style.css',
'options' => [
'treeshake' => 1,
'wpr_email' => '[email protected]',
'wpr_key' => 'SuperSecretRocketeerKey',
'rucss_safelist' => [ 'http://example.com/my/safe/css.css' ],
Expand Down
1 change: 0 additions & 1 deletion tests/Fixtures/inc/Engine/Optimization/RUCSS/Controller/UsedCSS/treeshake.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
'safelist' => [],
'skipped_attr' => [],
'config' => [
'treeshake' => 1,
'rucss_safelist' => [],
'skip_attr' => [],
'is_mobile' => false,
Expand Down
Loading