Closes #7242 3.19 - Preload Fonts - Data insertion part

[Khadreal]

Description

Add database structure and ajax for preload fonts
Fixes #7242

Type of change

• New feature (non-breaking change which adds functionality).

Detailed scenario

N/A

Technical description

Documentation

Add 3.19 database structure, ajax controller.

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for f8142151	❌ 42.20% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (f814215)	Report Missing	Report Missing	Report Missing
Head commit (bf19eae)	39194	17180	43.83%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7274)	109	46	42.20%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[jeawhanlee]

@wordpressfan For preload fonts, we did agree to only store the font url in a JSON array right?

[jeawhanlee]

@Khadreal I think we need to update the mock data in the test to be just JSON array of font urls

CC: @wordpressfan

[Mai-Saad]

@Khadreal Thanks for the PR. During exploratory can see

• The table wasn't created after a fresh install
• Fatal error when try to delete wpr

[10-Feb-2025 12:31:25 UTC] PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function WPRocketUninstall::__construct(), 6 passed in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php on line 38 and exactly 7 expected in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Engine/WPRocketUninstall.php:158
Stack trace:
#0 /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php(38): WPRocketUninstall->__construct()
#1 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(1314): include_once('...')
#2 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(970): uninstall_plugin()
#3 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/ajax-actions.php(4771): delete_plugins()
#4 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(324): wp_ajax_delete_plugin()
#5 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#6 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()
#7 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/admin-ajax.php(192): do_action()
#8 {main}
  thrown in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Engine/WPRocketUninstall.php on line 158

can you please check 🙏

[Mai-Saad]

@Khadreal Can you please check this error when 🙏
1- fresh install (no activation)
2- delete the plugin

[19-Feb-2025 09:42:13 UTC] PHP Fatal error:  Uncaught Error: Class "WP_Rocket\Engine\Media\PreloadFonts\Database\Table\PreloadFonts" not found in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php:38
Stack trace:
#0 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(1314): include_once()
#1 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(970): uninstall_plugin()
#2 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/ajax-actions.php(4771): delete_plugins()
#3 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(324): wp_ajax_delete_plugin()
#4 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#5 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()
#6 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/admin-ajax.php(192): do_action()
#7 {main}
  thrown in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php on line 38

[Khadreal]

@Khadreal Can you please check this error when 🙏 1- fresh install (no activation) 2- delete the plugin

[19-Feb-2025 09:42:13 UTC] PHP Fatal error:  Uncaught Error: Class "WP_Rocket\Engine\Media\PreloadFonts\Database\Table\PreloadFonts" not found in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php:38
Stack trace:
#0 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(1314): include_once()
#1 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/plugin.php(970): uninstall_plugin()
#2 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/includes/ajax-actions.php(4771): delete_plugins()
#3 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(324): wp_ajax_delete_plugin()
#4 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#5 /var/www/new.rocketlabsqa.ovh/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()
#6 /var/www/new.rocketlabsqa.ovh/htdocs/wp-admin/admin-ajax.php(192): do_action()
#7 {main}
  thrown in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/uninstall.php on line 38

Fixed @Mai-Saad

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for f8142151	✅ 69.77% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (f814215)	Report Missing	Report Missing	Report Missing
Head commit (26ac802)	39257	17258	43.96%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7274)	172	120	69.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Mai-Saad]

Working fine

• table structure matches lrc (but both different than lcp in terms of having created at + error msg is []) => if we are good there and nothing is needed for codacy then we can merge
• This part of AC can't be tested on this PR and shall be checked later

Any possible error will be saved into the DB and status set to failed
If no fonts are found, we’ll save this fact to the database and set the status to completed
Remove failed jobs (the behaviour should be the same as with other priority elements features)

[Khadreal]

• of AC can't be tested on this PR and

• error msgs is [] for lrc and preload fonts cause the way we handle it when not found is by sending empty array unlike lcp where we send 'not found'
• Codacy can't be improved further I think 🤔

To unblock other issues, I'll move forward with this by merging the PR