-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7246 3.19 - Preconnect to external domains - Beacon insertion part #7301
base: feature/7248-data-insertion-part
Are you sure you want to change the base?
Closes #7246 3.19 - Preconnect to external domains - Beacon insertion part #7301
Conversation
653c3c4
to
74a587c
Compare
Test is failing which would be resolve when this issue is completed. |
Changes seems ok to me, however need to fix the tests if it's possible @Khadreal |
Left a comment here #7301 (comment), the tests failing are dependent on the #7248 PR |
# Conflicts: # inc/Engine/Media/PreconnectExternalDomains/Database/Queries/PreconnectExternalDomains.php # inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php # inc/Plugin.php
# Conflicts: # inc/Engine/Media/PreconnectExternalDomains/Context/Context.php # inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
# Conflicts: # inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
8febaa1
to
795fd1d
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Description
Fixes #7246
Type of change
Detailed scenario
N/A
Technical description
Documentation
Add factory class for Preload fonts to service provider
Mandatory Checklist
Code validation
Code style