Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7246 3.19 - Preconnect to external domains - Beacon insertion part #7301

Open
wants to merge 10 commits into
base: feature/7248-data-insertion-part
Choose a base branch
from

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #7246

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

N/A

Technical description

Documentation

Add factory class for Preload fonts to service provider

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal self-assigned this Feb 11, 2025
@Khadreal Khadreal marked this pull request as ready for review February 12, 2025 12:46
@Khadreal Khadreal force-pushed the feature/7246-beacon-insertion-part branch from 653c3c4 to 74a587c Compare February 13, 2025 11:13
@Khadreal Khadreal requested a review from a team February 13, 2025 13:12
@Khadreal
Copy link
Contributor Author

Test is failing which would be resolve when this issue is completed.

@Miraeld Miraeld linked an issue Feb 14, 2025 that may be closed by this pull request
@Khadreal Khadreal changed the base branch from feature/preload-fonts to feature/preconnect-external-domains February 17, 2025 11:55
@Miraeld
Copy link
Contributor

Miraeld commented Feb 18, 2025

Changes seems ok to me, however need to fix the tests if it's possible @Khadreal

@MathieuLamiot
Copy link
Contributor

MathieuLamiot commented Feb 18, 2025

@Khadreal @Miraeld Should this go back to In Progress then?
If this needs another PR to fix the test, please write it down here so we can know what needs to be done.

@Khadreal
Copy link
Contributor Author

fix the test, please write it down

Left a comment here #7301 (comment), the tests failing are dependent on the #7248 PR

# Conflicts:
#	inc/Engine/Media/PreconnectExternalDomains/Database/Queries/PreconnectExternalDomains.php
#	inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
#	inc/Plugin.php
# Conflicts:
#	inc/Engine/Media/PreconnectExternalDomains/Context/Context.php
#	inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
# Conflicts:
#	inc/Engine/Media/PreconnectExternalDomains/ServiceProvider.php
@Khadreal Khadreal force-pushed the feature/7246-beacon-insertion-part branch from 8febaa1 to 795fd1d Compare February 19, 2025 11:10
@Khadreal Khadreal changed the base branch from feature/preconnect-external-domains to feature/7248-data-insertion-part February 19, 2025 11:10
Copy link

codacy-production bot commented Feb 19, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -0.10%) 26.83% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b7d7412) 39176 17188 43.87%
Head commit (5d1a868) 39217 (+41) 17224 (+36) 43.92% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7301) 41 11 26.83%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal requested review from Miraeld and a team February 19, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.19 - Preconnect to external domains - Beacon insertion part
3 participants