-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CICD-883] Update @changesets/cli to 2.27.10 #109
Conversation
|
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was added in commit 01b5b17. Did that somehow sneak into this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch; I must've based this PR on the wrong branch 🙃
Just rebased onto main
and pushed up, all should be good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back, there is a failing test now 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm:
Unable to find image 'wpengine/site-deploy:1.0.4' locally
docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen that happen occasionally. Not entirely sure how we'd be hitting a rate limit, but you should be able to re-run.
Resolves a vulnerability from a transitive dependency of the changesets package.
03439a4
to
d07e5d6
Compare
JIRA Ticket
CICD-833
What Are We Doing Here
Sister PR to wpengine/site-deploy#41, updating the same deps.
Resolves a vulnerability with a transitive dependency of @changesets/cli, which was patched in @changesets/cli 2.7.10.
Since @changesets/cli is a dev dependency for the repo, risk of releasing this change is low.
Offending transitive dependency tree before and after: