Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD-883] Update @changesets/cli to 2.27.10 #109

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mike-day
Copy link
Member

@mike-day mike-day commented Dec 9, 2024

JIRA Ticket

CICD-833

What Are We Doing Here

Sister PR to wpengine/site-deploy#41, updating the same deps.

Resolves a vulnerability with a transitive dependency of @changesets/cli, which was patched in @changesets/cli 2.7.10.

Since @changesets/cli is a dev dependency for the repo, risk of releasing this change is low.


Offending transitive dependency tree before and after:

Screenshot 2024-12-04 at 11 46 45 AM Screenshot 2024-12-04 at 11 46 33 AM

@mike-day mike-day requested a review from a team as a code owner December 9, 2024 16:00
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 03439a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was added in commit 01b5b17. Did that somehow sneak into this branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch; I must've based this PR on the wrong branch 🙃

Just rebased onto main and pushed up, all should be good now!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back, there is a failing test now 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm:

Unable to find image 'wpengine/site-deploy:1.0.4' locally
docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that happen occasionally. Not entirely sure how we'd be hitting a rate limit, but you should be able to re-run.

Resolves a vulnerability from a transitive dependency of the changesets package.
@mike-day mike-day force-pushed the CICD-833-update-changesets-cli-gha branch from 03439a4 to d07e5d6 Compare December 10, 2024 16:40
@mike-day mike-day merged commit ff38299 into main Dec 10, 2024
3 checks passed
@mike-day mike-day deleted the CICD-833-update-changesets-cli-gha branch December 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants