Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Next.js WP Theme rendered blocks #115

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

docs: Next.js WP Theme rendered blocks #115

wants to merge 12 commits into from
+5,501 −0

Conversation

whoami-pwd
Copy link
Contributor

@whoami-pwd whoami-pwd commented Mar 25, 2025 •
edited
Loading

Issue

Provides an example of fetching WP Global Stylesheet:

  • An example WP Plugin
  • An example WP Global Stylesheet Fetching Script
  • Description in READM.md

@whoami-pwd whoami-pwd changed the title Example: Next.js WP Theme rendered blocks feat: Next.js WP Theme rendered blocks comand Mar 25, 2025
@whoami-pwd whoami-pwd marked this pull request as ready for review March 27, 2025 09:46
@whoami-pwd whoami-pwd requested a review from a team as a code owner March 27, 2025 09:46
moonmeister
moonmeister requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. Do folks need to include https://developer.wordpress.org/block-editor/reference-guides/packages/packages-base-styles/ ??

@whoami-pwd whoami-pwd changed the title feat: Next.js WP Theme rendered blocks comand feat: Next.js WP Theme rendered blocks Apr 3, 2025
moonmeister
moonmeister requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be its own example, not a modification of a previous example. Thanks.

@whoami-pwd whoami-pwd force-pushed the example-wp-theme-rendered-blocks branch from 5b32846 to 0760b8e Compare April 7, 2025 11:40
@whoami-pwd whoami-pwd requested a review from moonmeister April 7, 2025 11:41
@whoami-pwd whoami-pwd mentioned this pull request Apr 7, 2025
Open
moonmeister
moonmeister reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, I'm not seeing a wp-env setup though.

@moonmeister moonmeister changed the title feat: Next.js WP Theme rendered blocks docs: Next.js WP Theme rendered blocks Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonmeister moonmeister moonmeister requested changes

@josephfusco josephfusco Awaiting requested review from josephfusco

@ahuseyn ahuseyn Awaiting requested review from ahuseyn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whoami-pwd @moonmeister