Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ command based examples don't all use CommandPtr #6601

Open
spacey-sooty opened this issue May 8, 2024 · 3 comments
Open

C++ command based examples don't all use CommandPtr #6601

spacey-sooty opened this issue May 8, 2024 · 3 comments
Labels
component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure.

Comments

@spacey-sooty
Copy link
Contributor

This is best practice and should be enforced across examples.
@rzblue
Copy link
Member

rzblue commented May 8, 2024

Related: #5921

@spacey-sooty
Copy link
Contributor Author

I'm not 100% sure why that is closed as completed... it still appears to be true

@ncorrea210
Copy link
Contributor

This comment on #5988 is related to this post. It comes down to the usage of Command* and CommandPtr simply representing different ownership semantics in RobotContainer.

@calcmogul calcmogul added component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure. labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@calcmogul @rzblue @ncorrea210 @spacey-sooty