Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cif 234 veg water change #91

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Cif 234 veg water change #91

wants to merge 10 commits into from

Conversation

weiqi-tori
Copy link
Member

https://gfw.atlassian.net/browse/CIF-234

TODO: layer generation and zonal stats use different spatial resolutions

@weiqi-tori weiqi-tori requested review from S-AI-F and tedw0ng November 11, 2024 06:14
Copy link
Member

@tedw0ng tedw0ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of returning (gain_pixels - loss_pixels) / start_pixels, can we return gain_area and loss_area, or (gain_area - loss_area)? I'm concerned that ratios are hard to use, but a user could calculate a ratio if desired if they could also get start_area.

@weiqi-tori
Copy link
Member Author

Instead of returning (gain_pixels - loss_pixels) / start_pixels, can we return gain_area and loss_area, or (gain_area - loss_area)? I'm concerned that ratios are hard to use, but a user could calculate a ratio if desired if they could also get start_area.

We could update the script to do that. Do we want it to be one indicator script with different options of output? Or multiple indicators using the same layer? We don't currently have indicator(s) like this in CIF. @chrowe @S-AI-F

@S-AI-F
Copy link
Member

S-AI-F commented Dec 6, 2024

Agree with @tedw0ng that the only ratio is hard to use as output. Since we don't have other metrics with multiple outputs and to keep the structure simple for now, @weiqi-tori i propose to develop them as sperate functions in the same metric script with one output by function (same logic as glad_lulc layer):

  • vegetation_water_change_gain_areas
  • vegetation_water_change_loss_areas
  • vegetation_water_change_gain_loss_ratio

What do you think @tedw0ng @weiqi-tori ?

@tedw0ng
Copy link
Member

tedw0ng commented Dec 6, 2024

Yes this would be fine. The non-ratio names should be *_area, not *_areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants