Fill in pre-process lambda for bulk OTF feature #86
Conversation
dmannarino
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/otf_lists #86 +/- ##
==================================================
Coverage 94.52% 94.52%
==================================================
Files 19 19
Lines 1261 1261
==================================================
Hits 1192 1192
Misses 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dmannarino
changed the title
| from raster_analysis.exceptions import QueryParseException | ||
| from raster_analysis.globals import LOGGER | ||
|
|
||
| patch(["boto3"]) | ||
|
|
||
| # FIXME: Get these from env | ||
| BUCKET = "gfw-pipelines-test" | ||
| REGION = "us-east-1" |
There was a problem hiding this comment.
OK for now, but don't forget to fix these lines before we check into staging (especially line 18).
|
|
||
| # FIXME: Hash those args for cacheability! | ||
| request_hash: UUID = uuid4() | ||
| geom_prefix = f"test/otf_lists/{str(request_hash)}/geometries.csv" |
There was a problem hiding this comment.
I think we can make this more concrete now, since it's already in a test bucket.
I'd prefer not to include "otf" in the path name because it requires knowing an acronym we may or may not still use in 3 years. Maybe something general like /analysis/jobs/input?
There was a problem hiding this comment.
@jterry64 Sounds good, but where does the hash go? How about /analysis/jobs/$hash/input and /analysis/jobs/$hash/output ?
| # FIXME: Hash those args for cacheability! | ||
| request_hash: UUID = uuid4() | ||
| geom_prefix = f"test/otf_lists/{str(request_hash)}/geometries.csv" | ||
| output_prefix = f"test/otf_lists/{str(request_hash)}/output" |
There was a problem hiding this comment.
Same here, maybe just /analysis/jobs/output?
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information