Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xray and add code guru profiling #94

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

solomon-negusse
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

This adds aws code guru profiler for method level profiling of the lambda functions

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@jterry64 jterry64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty sweet, it doesn't need any setup outside the code (e.g. in terraform)?

@jterry64
Copy link
Member

I do see tests are failing due to issues with finding the right lambda layers, is there some confusion here for hotfixes @dmannarino?

@solomon-negusse
Copy link
Member Author

solomon-negusse commented Aug 22, 2024

I do see tests are failing due to issues with finding the right lambda layers, is there some confusion here for hotfixes @dmannarino?

The tests actually pass, @jterry64 but the deployment to dev did fail. I got around this by temporarily deploying from my machine with the available layer version and assumed it's a dev only issue but would be good for @dmannarino to help explain this.

@solomon-negusse
Copy link
Member Author

Looks pretty sweet, it doesn't need any setup outside the code (e.g. in terraform)?

That would be nice to add. For now, I added the code guru profiling group manually to initially see if we'll get something useful out of this.

@dmannarino
Copy link
Member

dmannarino commented Aug 22, 2024

Hmm, will look into right after lunch.

Thanks @dmannarino, here is where the build starts to fail with missing lambda layers: https://github.com/wri/gfw-raster-analysis-lambda/actions/runs/10510949787/job/29120775169#step:10:1395

@solomon-negusse solomon-negusse merged commit 8034fe0 into master Aug 23, 2024
2 of 3 checks passed
@solomon-negusse solomon-negusse deleted the feature/lambda-profiler branch August 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants