Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLAG-1012] Update privacy policy language #4761

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

SARodrigues
Copy link
Collaborator

@SARodrigues SARodrigues commented Mar 8, 2024

Overview

This PR updates the Privacy Policy text in order to match the updated copy/version in the main WRI website, as per task's description.

Notes:
I made a couple quick changes, unrequested, under review by the QA team:

  • I've noticed WRI's Privacy Policy often mentions other sections, which are linked to the respective section via hash tags. This was not working nor implemented at all in the GFW website; I took the liberty of implementing it (no animations, just making them work. If necessary, we can animate the scroll later on)
  • Verified that all links have rel="noopener noreferrer"
    Some were missing it. noopener ends up being redundant in this context, but as standard practice I've added both anyways.
  • While going through the Privacy Policy, I noticed it was both pretty much unstyled but also extremely difficult to read. I took the liberty of adding a couple styling tweaks, very basic just to improve spacing and readability, mostly focused on:
    • Sized of the headers
    • Spacing of the sections
    • Spacing of the lists
      This doesn't match the ToS, which are also majorly unstyled, waiting from input on the QA team as to whether:
      • Keep the changes
      • Possibly improve ToS spacing as well
      • Revert it (takes a couple minutes)
  • There are references to the cookie policy, including a link to open the settings, which works on the main WRI website but doesn't apply here. Waiting on input from the QA team on whether to:
    • Remove the references
    • Reword them to match the GFW cookie system.

Relevant tickets

FLAG-1012

@SARodrigues SARodrigues self-assigned this Mar 8, 2024
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4761 March 8, 2024 14:27 Inactive
@SARodrigues SARodrigues requested a review from wri7tno March 8, 2024 14:30
@SARodrigues SARodrigues temporarily deployed to gfw-staging-pr-4761 March 13, 2024 11:41 Inactive
Copy link
Collaborator

@wri7tno wri7tno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@willian-viana willian-viana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SARodrigues SARodrigues merged commit f23cc52 into develop Apr 22, 2024
4 checks passed
@SARodrigues SARodrigues deleted the FLAG-1012-update-privacy-policy-language branch April 22, 2024 13:21
@SARodrigues SARodrigues mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants