[TM-1711] update bulkUpdateJobs to allow updating a single job that i… #60
Conversation
|
View your CI Pipeline Execution ↗ for commit 89b210a.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
This looks OK, but there appears to be some spec updates needed. It's also worth noting that while this may make it look like the job cancelled in the FE, the worker process in the PHP BE will still run to completion, so whatever action the user was trying to take in the FE, it will eventually still try to finish in the BE, so this isn't a real "cancel". I don't know that we have a good way to effectively cancel the BE job though, so I suppose this is the best we can do... I'm curious about the need for this though. Is product aware that this won't cancel the actual work?
|
|
||
| await expect(controller.bulkUpdateJobs(payload, request)).rejects.toThrow(NotFoundException); | ||
| }); | ||
| // it('should not update jobs with status "pending"', async () => { |
There was a problem hiding this comment.
Please do not merge commented out code.
Task Link