[TM-785] Unit testing and linting for the BE repo #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y in a single test run.
I'm torn on this approach for setting up the roles, but it's what we're using and leaving it commented out in tests is making the tests fail when run in isolation. The --fresh flag should never be needed, and without it the artisan command is quick and idempotent.
roguenet
force-pushed
the
feat/TM-785-unit-tests
branch
3 times, most recently
from
9d85f0f to
353c15b
Compare
roguenet
force-pushed
the
feat/TM-785-unit-tests
branch
from
353c15b to
5818748
Compare
roguenet
commented
Apr 9, 2024
| { | ||
| if (! config('app.sns.enabled')) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
We should likely remove the SNS integration entirely as it's only useful for mobile apps, but for now this will do.
| @@ -392,7 +390,7 @@ | |||
| Route::get('/projects', ViewMyProjectsController::class); | |||
| }); | |||
|
|
|||
| Route::post('/users/resend', [AuthController::class, 'resendByEmail']); | |||
| Route::post('/users/resend', [AuthController::class, 'resendByEmail'])->withoutMiddleware('auth:service-api-key,api'); | |||
There was a problem hiding this comment.
This was the first bug found by the resurrected test suite. This endpoint currently doesn't work in production, but as far as I know nobody has reported it yet.
pachonjcl
approved these changes
Apr 10, 2024
egrojMonroy
pushed a commit
that referenced
this pull request
Nov 1, 2024
[TM-785] Unit testing and linting for the BE repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-785
make teststaging,mainorrelease/**