[TM-812] Tree Species refactor #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age doesn't need to load the entity too.
roguenet
commented
Apr 13, 2024
| @@ -208,24 +242,31 @@ private function updateLinkedFieldValue(array $linkedFieldInfo, $answer): void | |||
| } | |||
| } | |||
|
|
|||
| public function getForm(): Form | |||
| private function syncRelation(string $property, $data): void | |||
There was a problem hiding this comment.
This is the real meat of this PR: Over the course of this epic, we'll be adding support for several (hopefully all) of these relations so that the BE is responsible for managing them, rather than putting that onus on the FE, requiring it to access a bunch of extra APIs. This is both for performance and practical reasons (see the note about the update request flow in the PR description).
pachonjcl
approved these changes
Apr 15, 2024
egrojMonroy
pushed a commit
that referenced
this pull request
Nov 1, 2024
[TM-812] Tree Species refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-812
FE: wri/wri-terramatch-website#116
This turns tree species into a BE concern by avoiding separate mutation endpoints for tree species (create/update/delete). The problem there was that in the update request flow, the tree species on the base entity would be updated without admin approval of the update request.
I've also started sideloading the update request on the form entity API response so that the FE doesn't need to load both endpoints in order to load the form.