polygon validation endpoints #145
Conversation
There was a problem hiding this comment.
I don't see any updates to the API docs. Please add documentation in the openapi-src directory, and update the swagger doc with make doc.
I've only made it about halfway through the PR, but need to sign off for the day and wanted to get the comments so far to you. I'll continue reviewing tomorrow.
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/V2/Terrafund/TerrafundCreateGeometryController.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I've finished my initial read through. I think I can take care of it during my greenhouse API work, but a lot of the validation methods in the create geometry controller are going to need to be moved to a utility more accessible somewhere. Also, I think there might be room to tap into the Laravel Validator system for a bunch of these, cleaning up the readability and maintainability of them. I'll look into that as well.
I do wish we had unit tests for all this new functionality, but in the interest of time I'll withhold requesting that for now.
Once we've resolved the remaining outstanding comments, this should be ready to merge.
app/Http/Controllers/V2/Terrafund/TerrafundEditGeometryController.php
Outdated
Show resolved
Hide resolved
…match-api into polygon_validation
|
The linter needs some attention, and then I think this is just about ready. |
…lidation endpoints (#145) * polygon validation endpoints * move code from migration to seeder * remove unused code * move code from migration to seeder * add missing pieces in docker file for php * fix lint * implement some suggestion on the model creation and uuid usage * change memory limit * merge single polygon of geo and dashboard * keep merging * add country in site_polygon migration and log error of site polygon * add Eloquent and clear query * add function to call area and latitude of polygon in model * add relation with polygon for site polygon * move to variable for clarity * fix: lint --------- Co-authored-by: JORGE <[email protected]> Co-authored-by: cesarLima1 <[email protected]>
…lidation endpoints (#145) * polygon validation endpoints * move code from migration to seeder * remove unused code * move code from migration to seeder * add missing pieces in docker file for php * fix lint * implement some suggestion on the model creation and uuid usage * change memory limit * merge single polygon of geo and dashboard * keep merging * add country in site_polygon migration and log error of site polygon * add Eloquent and clear query * add function to call area and latitude of polygon in model * add relation with polygon for site polygon * move to variable for clarity * fix: lint --------- Co-authored-by: JORGE <[email protected]> Co-authored-by: cesarLima1 <[email protected]>
Polygon Validation work
Notes:
Rebuild php container or make sure that the memory for upload and post are increased.
make sure to create the following 3 folders inside
storage/app/public/: [geojson_files,kml_files,shapefiles]Please make run the
database/seeders/CodeCriteria.phpanddatabase/seeders/CodeIndicator.phpDocumentation