[TM-833] Allow creation of new frameworks without breaking existing API access. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roguenet
commented
Apr 15, 2024
| @@ -33,7 +33,7 @@ protected function isolateAuthorizedFrameworks(QueryBuilder $query, string $tabl | |||
| $query->where(function ($query) use ($tableName, $frameworkNames, $user) { | |||
| foreach ($frameworkNames as $framework) { | |||
| $frameworkPermission = 'framework-' . $framework; | |||
| if ($user->hasPermissionTo($frameworkPermission)) { | |||
There was a problem hiding this comment.
can and hasPermissionTo appear to consistently test the same thing, but can simply returns false instead of throwing an error when the Permission hasn't been defined.
pachonjcl
approved these changes
Apr 16, 2024
egrojMonroy
pushed a commit
that referenced
this pull request
Nov 1, 2024
[TM-833] Allow creation of new frameworks without breaking existing API access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-833
I've also done a couple of other things:
framework-terrafund-enterprisespermission in anticipation of the new framework mentioned in the ticket.