[TM-920] Store PointGeometry in the GH API bulk upload geometry endpoint. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attribute getters from PolygonGeometry.
cesarLima1
approved these changes
Jun 5, 2024
Comment on lines
554
to
557
| Route::get('/export', ExportAllSiteDataAsProjectDeveloperController::class); | ||
| // deprecated, use POST api/v2/geometry instead (include site_id in the geometry's properties | ||
| Route::post('/geometry', [GeometryController::class, 'storeSiteGeometry']); | ||
| }); |
There was a problem hiding this comment.
Just out of curiosity, will the deprecated endpoint Route::post('/geometry', [GeometryController::class, 'storeSiteGeometry']); be removed in the future?
There was a problem hiding this comment.
Yeah, I'd like to remove it as soon as I get confirmation from GH that they've switched to the other endpoint. Hopefully this won't be too disruptive for them since they're still in development on this API integration and it's not in their prod environment yet.
egrojMonroy
pushed a commit
that referenced
this pull request
Nov 1, 2024
[TM-920] Store PointGeometry in the GH API bulk upload geometry endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-920