Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM-1536] add delayed job progress #593

Merged
merged 9 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use App\Helpers\GeometryHelper;
use App\Http\Resources\DelayedJobResource;
use App\Jobs\FixPolygonOverlapJob;
use App\Models\DelayedJob;
use App\Models\DelayedJobProgress;
use App\Models\V2\Sites\CriteriaSite;
use App\Models\V2\Sites\Site;
use App\Models\V2\Sites\SitePolygon;
Expand All @@ -25,7 +25,9 @@ public function clipOverlappingPolygonsBySite(string $uuid)
ini_set('memory_limit', '-1');
$user = Auth::user();
$polygonUuids = GeometryHelper::getSitePolygonsUuids($uuid)->toArray();
$delayedJob = DelayedJob::create();
$delayedJob = DelayedJobProgress::create([
'processed_content' => 0,
]);
$job = new FixPolygonOverlapJob($delayedJob->id, $polygonUuids, $user->id);
dispatch($job);

Expand All @@ -41,7 +43,9 @@ public function clipOverlappingPolygonsOfProjectBySite(string $uuid)
$sitePolygon = Site::isUuid($uuid)->first();
$projectId = $sitePolygon->project_id ?? null;
$polygonUuids = GeometryHelper::getProjectPolygonsUuids($projectId);
$delayedJob = DelayedJob::create();
$delayedJob = DelayedJobProgress::create([
'processed_content' => 0,
]);
$job = new FixPolygonOverlapJob($delayedJob->id, $polygonUuids, $user->id);
dispatch($job);

Expand Down Expand Up @@ -89,7 +93,9 @@ public function clipOverlappingPolygons(Request $request)
$delayedJob = null;
if (! empty($uniquePolygonUuids)) {
$user = Auth::user();
$delayedJob = DelayedJob::create();
$delayedJob = DelayedJobProgress::create([
'processed_content' => 0,
]);
$job = new FixPolygonOverlapJob($delayedJob->id, $polygonUuids, $user->id);
dispatch($job);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use App\Jobs\InsertGeojsonToDBJob;
use App\Jobs\RunSitePolygonsValidationJob;
use App\Models\DelayedJob;
use App\Models\DelayedJobProgress;
use App\Models\V2\PolygonGeometry;
use App\Models\V2\Sites\Site;
use App\Models\V2\Sites\SitePolygon;
Expand Down Expand Up @@ -1219,7 +1220,10 @@ public function runSiteValidationPolygon(Request $request)
$uuid = $request->input('uuid');

$sitePolygonsUuids = GeometryHelper::getSitePolygonsUuids($uuid)->toArray();
$delayedJob = DelayedJob::create();
$delayedJob = DelayedJobProgress::create([
'total_content' => count($sitePolygonsUuids),
'processed_content' => 0,
]);
$job = new RunSitePolygonsValidationJob($delayedJob->id, $sitePolygonsUuids);
dispatch($job);

Expand All @@ -1235,7 +1239,10 @@ public function runPolygonsValidation(Request $request)
{
try {
$uuids = $request->input('uuids');
$delayedJob = DelayedJob::create();
$delayedJob = DelayedJobProgress::create([
'total_content' => count($uuids),
'processed_content' => 0,
]);
$job = new RunSitePolygonsValidationJob($delayedJob->id, $uuids);
dispatch($job);

Expand Down
24 changes: 24 additions & 0 deletions app/Http/Resources/DelayedJobProgressResource.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php

namespace App\Http\Resources;

use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;

class DelayedJobProgressResource extends JsonResource
{
/**
* Transform the resource into an array.
*
* @return array<string, mixed>
*/
public function toArray(Request $request): array
{
return [
'message' => $this->message ?? 'Job dispatched',
'job_uuid' => $this->uuid,
'proccessed_content' => $this->processed_content,
'total_content' => $this->total_content,
];
}
}
8 changes: 5 additions & 3 deletions app/Jobs/FixPolygonOverlapJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use App\Http\Middleware\SetAuthenticatedUserForJob;
use App\Models\DelayedJob;
use App\Models\DelayedJobProgress;
use App\Services\PolygonService;
use Exception;
use Illuminate\Bus\Queueable;
Expand Down Expand Up @@ -63,14 +64,15 @@ public function handle(): void
{

try {
$delayedJob = DelayedJob::findOrFail($this->delayed_job_id);
$delayedJob = DelayedJobProgress::findOrFail($this->delayed_job_id);
$user = Auth::user();
if ($user) {
$polygonsClipped = App::make(PolygonService::class)->processClippedPolygons($this->polygonUuids);
$polygonsClipped = App::make(PolygonService::class)->processClippedPolygons($this->polygonUuids, $this->delayed_job_id);
$delayedJob->update([
'status' => DelayedJob::STATUS_SUCCEEDED,
'status' => DelayedJobProgress::STATUS_SUCCEEDED,
'payload' => json_encode(['updated_polygons' => $polygonsClipped]),
'status_code' => Response::HTTP_OK,
'progress' => 100,
]);
}
} catch (Exception $e) {
Expand Down
9 changes: 7 additions & 2 deletions app/Jobs/RunSitePolygonsValidationJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace App\Jobs;

use App\Models\DelayedJob;
use App\Models\DelayedJobProgress;
use App\Services\PolygonValidationService;
use Exception;
use Illuminate\Bus\Queueable;
Expand Down Expand Up @@ -48,7 +49,7 @@ public function __construct(string $delayed_job_id, array $sitePolygonsUuids)
public function handle(PolygonValidationService $validationService)
{
try {
$delayedJob = DelayedJob::findOrFail($this->delayed_job_id);
$delayedJob = DelayedJobProgress::findOrFail($this->delayed_job_id);
foreach ($this->sitePolygonsUuids as $polygonUuid) {
$request = new Request(['uuid' => $polygonUuid]);
$validationService->validateOverlapping($request);
Expand All @@ -60,12 +61,16 @@ public function handle(PolygonValidationService $validationService)
$validationService->getGeometryType($request);
$validationService->validateEstimatedArea($request);
$validationService->validateDataInDB($request);

$delayedJob->increment('processed_content');
$delayedJob->save();
}

$delayedJob->update([
'status' => DelayedJob::STATUS_SUCCEEDED,
'status' => DelayedJobProgress::STATUS_SUCCEEDED,
'payload' => ['message' => 'Validation completed for all site polygons'],
'status_code' => Response::HTTP_OK,
'progress' => 100,
]);

} catch (Exception $e) {
Expand Down
21 changes: 21 additions & 0 deletions app/Models/DelayedJobProgress.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

namespace App\Models;

class DelayedJobProgress extends DelayedJob
{
public function __construct(array $attributes = [])
{
parent::__construct($attributes);

$this->fillable = array_merge($this->fillable, [
'processed_content',
'total_content',
]);

$this->casts = array_merge($this->casts, [
'processed_content' => 'integer',
'total_content' => 'integer',
]);
}
}
10 changes: 9 additions & 1 deletion app/Services/PolygonService.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use App\Helpers\CreateVersionPolygonGeometryHelper;
use App\Helpers\GeometryHelper;
use App\Helpers\PolygonGeometryHelper;
use App\Models\DelayedJobProgress;
use App\Models\V2\PointGeometry;
use App\Models\V2\PolygonGeometry;
use App\Models\V2\ProjectPitch;
Expand Down Expand Up @@ -562,13 +563,16 @@ public function insertGeojsonToDBFromContent(string $geojsonData, ?string $entit
}
}

public function processClippedPolygons(array $polygonUuids)
public function processClippedPolygons(array $polygonUuids, $delayed_job_id = null)
{
$geojson = GeometryHelper::getPolygonsGeojson($polygonUuids);

$clippedPolygons = App::make(PythonService::class)->clipPolygons($geojson);
$uuids = [];

$delayedJob = DelayedJobProgress::findOrFail($delayed_job_id);

Log::info('test now selected plygons');
if (isset($clippedPolygons['type']) && $clippedPolygons['type'] === 'FeatureCollection' && isset($clippedPolygons['features'])) {
foreach ($clippedPolygons['features'] as $feature) {
if (isset($feature['properties']['poly_id'])) {
Expand All @@ -591,8 +595,12 @@ public function processClippedPolygons(array $polygonUuids)
}

if (! empty($uuids)) {
$delayedJob->total_content = count($newPolygonUuids);
$delayedJob->save();
foreach ($newPolygonUuids as $polygonUuid) {
App::make(PolygonValidationService::class)->runValidationPolygon($polygonUuid);
$delayedJob->increment('processed_content');
$delayedJob->save();
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration {
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
Schema::table('delayed_jobs', function (Blueprint $table) {
$table->unsignedInteger('processed_content')->nullable()->after('payload');
$table->unsignedInteger('total_content')->nullable()->after('processed_content');
});
}

/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
Schema::table('delayed_jobs', function (Blueprint $table) {
$table->dropColumn(['proccessed_content', 'total_content']);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the other property

});
}
};
Loading