fixing PR comments

wri · May 30, 2024 · 0cc5ccd · 0cc5ccd
1 parent 1b8d1f0
commit 0cc5ccd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/admin/components/App.tsx b/src/admin/components/App.tsx
@@ -64,7 +64,7 @@ const App = () => {
         edit={modules.fundingProgramme.Edit}
         show={modules.fundingProgramme.Show}
         create={modules.fundingProgramme.Create}
-        icon={() => <Icon className="h-8 w-8" name={IconNames.FUJDING_PROGRAMMES} />}
+        icon={() => <Icon className="h-8 w-8" name={IconNames.FUNDING_PROGRAMMES} />}
         options={{ label: "Funding Programmes" }}
       />
       <Resource

diff --git a/src/admin/components/ResourceTabs/ChangeRequestsTab/useFormChanges.ts b/src/admin/components/ResourceTabs/ChangeRequestsTab/useFormChanges.ts
@@ -1,4 +1,5 @@
 import { useT } from "@transifex/react";
+import { isEqual } from "lodash";
 import { useMemo } from "react";
 
 import { getFormEntries } from "@/components/extensive/WizardForm/FormSummaryRow";
@@ -50,7 +51,7 @@ export default function useFormChanges(current: any, changed: any, steps: FormSt
               title: entry.title,
               type: entry.type,
               currentValue,
-              newValue: currentValue === newValue ? undefined : newValue
+              newValue: isEqual(currentValue, newValue) ? undefined : newValue
             };
           })
         };

diff --git a/src/components/extensive/Icon/Icon.tsx b/src/components/extensive/Icon/Icon.tsx
@@ -107,7 +107,7 @@ export enum IconNames {
   FORMS = "forms",
   APPLICATIONS = "applications",
   REPORTING_FRAMEWORKS = "reporting-frameworks",
-  FUJDING_PROGRAMMES = "funding-programmes",
+  FUNDING_PROGRAMMES = "funding-programmes",
   PITCHES = "pitches",
   ORGANISATIONS = "organisations",
   USERS = "users",