Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Update Components with Latest Changes #240

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Conversation

dottyy
Copy link
Collaborator

@dottyy dottyy commented Jun 6, 2024

This PR updates several components of the application, including:

Styles:

Adjustment of colors, sizes, and margins for greater visual consistency.
Example: IconSocial now has h-9 w-9 and background #002633.
Bug Fixes:

Spelling error corrected.
Logic Improvements:

Performance optimization and state management enhancements.
Dependency Updates:

Updated storybook to resolve compatibility issues.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wri-terramatch-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:06pm
wri-terramatch-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:06pm

@vercel vercel bot temporarily deployed to Preview – wri-terramatch-storybook June 7, 2024 13:44 Inactive
@dottyy dottyy marked this pull request as ready for review June 7, 2024 13:47
@dottyy dottyy requested a review from pachonjcl June 7, 2024 13:47
pachonjcl
pachonjcl previously approved these changes Jun 7, 2024
@dottyy dottyy requested a review from roguenet June 7, 2024 13:53
@dottyy
Copy link
Collaborator Author

dottyy commented Jun 7, 2024

Hi @roguenet . When you have a moment, could you please review this PR? It includes updates to several components, style adjustments, and some error corrections.

Thank you so much!

@roguenet
Copy link
Collaborator

roguenet commented Jun 7, 2024

The tests are failing; please investigate after addressing the feedback. You can run the tests locally with yarn test:ci and if you need to regenerate storybook snapshots, that can be done with yarn run jest --ci src/storybook.test.ts --updateSnapshot

Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have test failures that aren't related to snapshots to look into as well.

src/components/extensive/Modal/ModalAdd.tsx Outdated Show resolved Hide resolved
@roguenet
Copy link
Collaborator

roguenet commented Jun 7, 2024

This is ready to merge once the test failure is addressed. Let me know if you need help tracking it down. I'd start by making sure all components that are part of this PR are showing up correctly in Storybook; it looks like something is choking somewhere in that render stack.

@dottyy
Copy link
Collaborator Author

dottyy commented Jun 7, 2024

@roguenet Thank you for reaching out! I'm working on addressing the test failure, but I'm having trouble pinpointing the issue. Could you help me track it down? I'm reviewing that all components are displaying correctly in Storybook. I really appreciate your assistance in resolving this. Any guidance you can provide will be greatly appreciated!

@roguenet
Copy link
Collaborator

roguenet commented Jun 7, 2024

@roguenet Thank you for reaching out! I'm working on addressing the test failure, but I'm having trouble pinpointing the issue. Could you help me track it down? I'm reviewing that all components are displaying correctly in Storybook. I really appreciate your assistance in resolving this. Any guidance you can provide will be greatly appreciated!

Sure I'll see if I can figure it out

Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like after your other changes, it was just that new snapshots needed to be generated.

@dottyy
Copy link
Collaborator Author

dottyy commented Jun 7, 2024

Looks like after your other changes, it was just that new snapshots needed to be generated.

Thank you so much !!!

@dottyy dottyy merged commit 7886851 into staging Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants