-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Update Components with Latest Changes #240
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @roguenet . When you have a moment, could you please review this PR? It includes updates to several components, style adjustments, and some error corrections. Thank you so much! |
The tests are failing; please investigate after addressing the feedback. You can run the tests locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have test failures that aren't related to snapshots to look into as well.
This is ready to merge once the test failure is addressed. Let me know if you need help tracking it down. I'd start by making sure all components that are part of this PR are showing up correctly in Storybook; it looks like something is choking somewhere in that render stack. |
@roguenet Thank you for reaching out! I'm working on addressing the test failure, but I'm having trouble pinpointing the issue. Could you help me track it down? I'm reviewing that all components are displaying correctly in Storybook. I really appreciate your assistance in resolving this. Any guidance you can provide will be greatly appreciated! |
Sure I'll see if I can figure it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like after your other changes, it was just that new snapshots needed to be generated.
Thank you so much !!! |
This PR updates several components of the application, including:
Styles:
Adjustment of colors, sizes, and margins for greater visual consistency.
Example: IconSocial now has h-9 w-9 and background #002633.
Bug Fixes:
Spelling error corrected.
Logic Improvements:
Performance optimization and state management enhancements.
Dependency Updates:
Updated storybook to resolve compatibility issues.