Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#314: Add new IP Address element, update hook. #319

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

komejo
Copy link
Contributor

@komejo komejo commented Sep 13, 2024

What issue(s) does this solve?

Adding a custom IP Address WebformElement to get the correct client IP address on Pantheon.

What is the new behavior?

  • Updated IP Address element that checks proxy headers and remote_addr.
  • Update hook to apply to existing webforms.

Profile requirements:

  • Does deploying this change require a change to config at the site level (choose one)?
    • No config change is required.
    • Yes, and I have written an update hook to apply these config changes.
    • Yes, and I've included updating instructions to be added to the release notes. The next release will need to be a major version increase. (Only do this in special cases.)

Site-level pull requests for testing. Only merge when these PRs are approved:

Create or update any site-level pull requests following the documentation

Checked on develop (TA to do)

  • Brasil
  • China
  • Indonesia

@komejo komejo requested a review from mariacha September 13, 2024 00:58
@komejo komejo mentioned this pull request Sep 13, 2024
3 tasks
Copy link
Collaborator

@mariacha mariacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot how much of a pain it is to update webforms -- thanks for doing that!

Can you also update the single provided webform:

'#default_value': '[webform_submission:ip-address]'

Once that's done, you can merged!

@mariacha mariacha assigned komejo and unassigned mariacha Sep 13, 2024
@komejo komejo merged commit 14202d9 into main Sep 16, 2024
1 check passed
@komejo komejo removed their assignment Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants