Skip to content

Fix(cli): Add the feature about getting env info from connectors #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 13, 2025

Conversation

8471919
Copy link
Contributor

@8471919 8471919 commented Apr 10, 2025

Description

  • Add the CLI logic for user to enter the env info from connectors.
    • process the duplicated env as one.
    • Add Env type (Tagged type. = branded type)
  • Fix the msw mock handler
    • fix the value of response from https://raw.githubusercontent.com/wrtnlabs/connectors/refs/heads/fix/connector_list/connectors-list.json according to modified connector info type.
  • Fix the regex in vitest.setup.ts because https://raw.githubusercontent.com/wrtnlabs/connectors/* request occurred an error. so add the /https:\/\/raw\.githubusercontent\.com\/wrtnlabs\/connectors\// to ALLOW_REGEX_LIST

Step

  1. When the user selects a connector, the CLI displays the number of Envs and asks if you want to enter Env information.
    image
  • about is removed from the statements.
  1. If user select no, pass to the next step. If user select yes, user can enter the env values.
    image
  • If user press the ctrl+c (Interrupt is occurred), the env enter is finished and pass to next step.

Notification

now, the url of connectors.ts and mocks/server/handler.ts is https://raw.githubusercontent.com/wrtnlabs/connectors/refs/heads/fix/connector_list/connectors-list.json.
however this is for agentica npx test. because connector's modification is not reflected in main branch yet.

  • after merge the connector's modification into main branch, we must modify the url of files into https://raw.githubusercontent.com/wrtnlabs/connectors/refs/heads/fix/connector_list/connectors-list.json.

Related PR

@8471919 8471919 self-assigned this Apr 10, 2025
Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

@agentica/benchmark

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/benchmark@358

agentica

npm i https://pkg.pr.new/wrtnlabs/agentica@358

@agentica/core

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/core@358

@agentica/chat

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/chat@358

create-agentica

npm i https://pkg.pr.new/wrtnlabs/agentica/create-agentica@358

pg-vector-selector-benchmark

npm i https://pkg.pr.new/wrtnlabs/agentica/pg-vector-selector-benchmark@358

@agentica/pg-vector-selector

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/pg-vector-selector@358

@agentica/rpc

npm i https://pkg.pr.new/wrtnlabs/agentica/@agentica/rpc@358

commit: 48cbff0

Copy link
Member

@ryoppippi ryoppippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We found the test bypassed. Please correct.

❌ tests make development slow
✅ tests can make sure that each component works fine, so it speeds up dev

@sunrabbit123 sunrabbit123 requested a review from ryoppippi April 11, 2025 07:32
@8471919
Copy link
Contributor Author

8471919 commented Apr 11, 2025

image
Last CLI UI(?)

…t to .env file when user select no in env question
@8471919
Copy link
Contributor Author

8471919 commented Apr 13, 2025

@sunrabbit123 I'll merge this issue at 5PM(KST)

@sunrabbit123 sunrabbit123 merged commit 06e70c7 into main Apr 13, 2025
11 checks passed
@sunrabbit123 sunrabbit123 deleted the fix/add_get_env_from_connector branch April 13, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants