Improve the post authentication handler to set the correct username in the carbon context for organization SSO users #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the carbon context for organization SSO users
|
PR builder started |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6871733604
|
PR builder completed |
sadilchamishka
commented
Nov 15, 2023
...rvice/src/main/java/org/wso2/carbon/identity/auth/service/handler/AuthenticationHandler.java
Outdated
Show resolved
Hide resolved
dewniMW
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
For the organization SSO users, the authentication valve will set the
userID@tenant-domainas the username. Hence the downstream tasks for using the username which set in the carbon context will fail. One way is to manually handle each places. Ex - wso2/identity-organization-management-core#114 when creating organizations/sharing applications, the correct authenticated username was required to fetch.Also there are number of places for the MyAccount related functions where username in the carbon context is heavily used. Hence resolving each places and fix for any future features based on the username in the carbon context may not be reliable for the organization users. Hence with this PR, set the correct username in the carbon context.
$subject
Related issues