Enable SMS OTP configuration retrieval from primary org #213
Conversation
|
PR builder started |
|
PR builder completed |
|
PR builder started |
...rbon/identity/notification/sender/tenant/config/NotificationSenderManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...rbon/identity/notification/sender/tenant/config/NotificationSenderManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7216958329
...rbon/identity/notification/sender/tenant/config/NotificationSenderManagementServiceImpl.java
Show resolved
Hide resolved
| * @return Primary tenant id. | ||
| * @throws OrganizationManagementException If an error occurred while getting the primary tenant id. | ||
| */ | ||
| private int getPrimaryTenantId() throws OrganizationManagementException { |
There was a problem hiding this comment.
Let's improve this method to pass tenant-domain (as an argument) and retrieve the primary tenant ID.
Let's add another method in organization management repo to getRootTenant(tenantDomain) where we can reduce few operations and will be helpful for someone in future.
There was a problem hiding this comment.
Let's address only the first comment.
There was a problem hiding this comment.
Addressed in #253.
Proposed changes in this pull request
$subject
This PR updates the SMS configuration retrieval process. Now, if SMS configurations are not found in a sub-organization, they will be fetched from the primary organization for event handling. However, API calls will only access configurations specific to their own organization and not inherit from the parent.
When should this PR be merged
Merge after
Relevant Issues