-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for In-memory template manager #256
Provide support for In-memory template manager #256
Conversation
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10577681037
...2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/DefaultTemplateManager.java
Outdated
Show resolved
Hide resolved
....carbon.email.mgt/src/test/java/org/wso2/carbon/email/mgt/OrganizationEmailTemplateTest.java
Outdated
Show resolved
Hide resolved
...2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/DefaultTemplateManager.java
Outdated
Show resolved
Hide resolved
...2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/DefaultTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Outdated
Show resolved
Hide resolved
...on.email.mgt/src/main/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManager.java
Show resolved
Hide resolved
...mail.mgt/src/test/java/org/wso2/carbon/email/mgt/store/InMemoryBasedTemplateManagerTest.java
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10608829457
Also with this change we dont need to persist default templates with server startup[1] and tenant creation[2].. So lets remove those and associate code that become unused with that.. In fact we can,
[1] Lines 144 to 146 in d610d0c
[2] Lines 48 to 56 in d610d0c
|
PR builder started |
Changes suggested through [1] will be addressed in another PR. [1] #256 (comment) |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10612848361
Recreating PR : #254
Describe the issue:
When introducing new notification templates (Email/SMS) and migrating customers to on-premises solutions, a data migration is currently required for existing tenants. However, with the removal of data migration support in upcoming Identity Server (IS) releases, we need to address this issue to ensure smooth template integration without relying on data migration.
Proposed changes in this pull request
Currently email/sms templates are stored in the registry, for any sub tenants we are not adding new templates when server startup. When creating any tenants we are adding default email templates to the registry per tenant, this leaves redundant data. With this fix, we are providing In-memory template manager which return default templates and act on read only mode.
Currently, it works with hybrid template manager and db-based template manager also.
Issue : wso2/product-is#20996