Refactor the code to utilize the application management service for retrieving the main application ID #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrieving the main application ID
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
============================================
+ Coverage 19.14% 19.21% +0.07%
+ Complexity 181 175 -6
============================================
Files 52 50 -2
Lines 2862 2659 -203
Branches 326 305 -21
============================================
- Hits 548 511 -37
+ Misses 2270 2107 -163
+ Partials 44 41 -3 ☔ View full report in Codecov by Sentry. |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11288434480
sadilchamishka
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A circular OSGI service dependency arose when implementing the changes related to PR #2581. To address this, the PR proposes a refactoring of the codebase by removing the
OrgApplicationManagerdependency and introducing a framework service to retrieve the main application ID for a specific shared app.