Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar warnings in TemplatePersistenceManagerFactory #277

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Nov 11, 2024

Proposed changes in this pull request

$subject.

image

Based on the above analysis,

  • Reduced code duplication
  • Improved method comments
  • Removed implementation specific method from the factory.

When should this PR be merged

Immediate

Follow up actions

N/A

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.14%. Comparing base (f8429eb) to head (834b2fd).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...bon/email/mgt/NotificationTemplateManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #277      +/-   ##
============================================
+ Coverage     17.02%   17.14%   +0.11%     
- Complexity      179      180       +1     
============================================
  Files            53       53              
  Lines          3042     3027      -15     
  Branches        335      332       -3     
============================================
+ Hits            518      519       +1     
+ Misses         2483     2467      -16     
  Partials         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg merged commit 3e7a7b1 into wso2-extensions:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants