Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to maintain version, created_at & updated_at values #295

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Dec 13, 2024

Proposed changes in this pull request

$subject. Related to,

When should this PR be merged

Immediate

Follow up actions

Db schema change (framework PR) and the application logic change (this PR) has to included in the product-is in the same commit.
PS: Done with,

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 31.99%. Comparing base (97740cd) to head (0178f61).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 0.00% 7 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 0.00% 7 Missing ⚠️
...arbon/email/mgt/store/dao/NotificationTypeDAO.java 0.00% 4 Missing ⚠️
.../org/wso2/carbon/email/mgt/util/I18nEmailUtil.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
+ Coverage     31.43%   31.99%   +0.55%     
- Complexity      468      479      +11     
============================================
  Files            72       72              
  Lines          4784     4804      +20     
  Branches        609      609              
============================================
+ Hits           1504     1537      +33     
+ Misses         3128     3111      -17     
- Partials        152      156       +4     
Flag Coverage Δ
unit 15.93% <5.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12316087440

@darshanasbg darshanasbg merged commit fb24796 into wso2-extensions:master Dec 13, 2024
2 of 4 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12316087440
Status: failure

@darshanasbg
Copy link
Contributor Author

PR builder started Link: https://github.com/wso2/product-is/actions/runs/12316087440

This is expected since, this PR require db schema change done in the framework too.. So went ahead with merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants