Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code which used to migrate from non-unicode to unicode #297

Merged

Conversation

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12405895291

@darshanasbg darshanasbg changed the title Cleanup code to migrate from non-unicode to unicode Cleanup code used to migrate from non-unicode to unicode Dec 19, 2024
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12405895291
Status: cancelled

@darshanasbg darshanasbg force-pushed the cleanup-unicode-migration branch from 73df7e2 to 9fbdc4f Compare December 19, 2024 03:52
@darshanasbg darshanasbg changed the title Cleanup code used to migrate from non-unicode to unicode Cleanup code which used to migrate from non-unicode to unicode Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 32.13%. Comparing base (2c2ed60) to head (9fbdc4f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 0.00% 13 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     29.89%   32.13%   +2.24%     
  Complexity      479      479              
============================================
  Files            72       72              
  Lines          5142     4771     -371     
  Branches        687      616      -71     
============================================
- Hits           1537     1533       -4     
+ Misses         3449     3082     -367     
  Partials        156      156              
Flag Coverage Δ
unit 16.34% <0.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12405895291

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12405895291
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12405895291

@darshanasbg darshanasbg merged commit 9eaf644 into wso2-extensions:master Dec 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants