-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reCaptcha enterprise support #684
Conversation
2c3d9ac
to
e94436f
Compare
e94436f
to
419168c
Compare
...ntity.captcha/src/main/java/org/wso2/carbon/identity/captcha/internal/CaptchaDataHolder.java
Outdated
Show resolved
Hide resolved
...ntity.captcha/src/main/java/org/wso2/carbon/identity/captcha/internal/CaptchaDataHolder.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...er.recovery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/Utils/RecoveryUtil.java
Outdated
Show resolved
Hide resolved
...er.recovery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/Utils/RecoveryUtil.java
Outdated
Show resolved
Hide resolved
...er.recovery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/Utils/RecoveryUtil.java
Outdated
Show resolved
Hide resolved
...ery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/impl/CaptchaApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
070fb0e
to
e1999b6
Compare
e1999b6
to
695cd10
Compare
f5cf5af
to
27a285a
Compare
...n.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaConstants.java
Outdated
Show resolved
Hide resolved
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
69e7bb4
to
597d2b8
Compare
9505f85
to
5cd52be
Compare
5cd52be
to
4556187
Compare
4556187
to
588fd18
Compare
...carbon.identity.captcha/src/main/java/org/wso2/carbon/identity/captcha/util/CaptchaUtil.java
Outdated
Show resolved
Hide resolved
...very/src/gen/java/org/wso2/carbon/identity/recovery/endpoint/dto/ReCaptchaPropertiesDTO.java
Outdated
Show resolved
Hide resolved
...er.recovery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/Utils/RecoveryUtil.java
Outdated
Show resolved
Hide resolved
...ery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/impl/CaptchaApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...ery/src/main/java/org/wso2/carbon/identity/recovery/endpoint/impl/CaptchaApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...tity.api.user.recovery/src/test/resources/repository/conf/identity/captcha-config.properties
Show resolved
Hide resolved
@@ -469,6 +470,11 @@ private static Properties validateCaptchaConfigs(Properties properties) { | |||
RecoveryUtil.handleBadRequest(String.format("%s is not found ", CaptchaConstants.RE_CAPTCHA_VERIFY_URL), | |||
Constants.STATUS_INTERNAL_SERVER_ERROR_MESSAGE_DEFAULT); | |||
} | |||
if (CaptchaConstants.RE_CAPTCHA_TYPE_ENTERPRISE.equals(reCaptchaType) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a comment here explaining whats happening here?
// Check if project id is available for reCaptcha Enterprise
<class name="org.wso2.carbon.identity.captcha.util.CaptchaUtilTest"/> | ||
</classes> | ||
</test> | ||
</suite> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
This PR is continued in #756 |
Proposed changes in this pull request
This PR is for adding the support for reCaptcha enterprise.
For the reCaptcha flows, in addition to the reCaptcha v2 and v3 support, reCaptcha enterprise support is added.
When should this PR be merged
Can be merged once reviewed and approved.
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation