Hash confirmation-code/otp used in recovery #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rc/main/java/org/wso2/carbon/identity/recovery/endpoint/impl/ValidateCodeApiServiceImpl.java
Outdated
Show resolved
Hide resolved
chamathns
reviewed
Oct 4, 2023
A migration will not be needed. This is written in a backward compatible way to handle already sent confirmation codes/OTPs. |
.../src/main/java/org/wso2/carbon/identity/recovery/confirmation/ResendConfirmationManager.java
Outdated
Show resolved
Hide resolved
...ain/java/org/wso2/carbon/identity/recovery/password/NotificationPasswordRecoveryManager.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Show resolved
Hide resolved
madurangasiriwardena
approved these changes
Oct 5, 2023
|
PR builder started |
chamathns
approved these changes
Oct 5, 2023
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6416420864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject
Related issue: