Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recaptcha prevalidator to handle multi attribute login scenario #774

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Refactor recaptcha prevalidator to handle multi attribute login scenario #774

merged 1 commit into from
Oct 17, 2023

Conversation

sandushi
Copy link
Contributor

Purpose

  • $subject

Changes from the PR

  • Currently we are not reading the failed attempts of the user when multi attribute login is enabled and use another identifier than username.
  • From this fix, we are fix to handle multi attribute login scenarios in the recaptcha pre validator.

Related issue

wso2/product-is#16918

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6533902167

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6533902167
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6536635339

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6536635339
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 16, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6536635339

@sandushi sandushi merged commit acecb3c into wso2-extensions:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@nilasini nilasini nilasini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandushi @jenkins-is-staging @nilasini