Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End tenant flow #785

Merged
merged 1 commit into from
Nov 29, 2023
Merged

End tenant flow #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ry/src/main/java/org/wso2/carbon/identity/recovery/listener/TenantManagementListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public void onTenantCreate(TenantInfoBean tenantInfoBean) throws StratosExceptio
PrivilegedCarbonContext.getThreadLocalCarbonContext().startTenantFlow();
PrivilegedCarbonContext.getThreadLocalCarbonContext().setTenantDomain(tenantDomain);
PrivilegedCarbonContext.getThreadLocalCarbonContext().setTenantId(tenantInfoBean.getTenantId());
PrivilegedCarbonContext.endTenantFlow();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can completely remove this listener if there is no any usage, or else at least this method, as it do nothing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are setting the tenant domain and the tenant id to the thread local here it seems. I didn't get why we could remove the method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot remove this listener as we delete recovery data during the tenant deletion:

identity-governance/components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/listener/TenantManagementListener.java

Line 91 in b708db6

UserRecoveryDataStore userRecoveryDataStore = JDBCRecoveryDataStore.getInstance();

also we cannot remove the onTenantCreate method since TenantManagementListener implements TenantMgtListener interface

}

@Override
Expand Down
Loading