Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert property UseNumeric to UseAlphaNumeric #789

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Dec 4, 2023

Proposed changes in this pull request

Adding reverted changes again after rebasing the branch with the upstream master branch.

Related PRs:

Resolves wso2/product-is#17073

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7084420890

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7084420890
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7084420890

@mpmadhavig mpmadhavig force-pushed the fix-change-emailotp-config-to-is-alphanumeric branch from 8667961 to efc3e29 Compare January 11, 2024 11:05
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7541846674

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7541846674
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7541846674

@mpmadhavig mpmadhavig force-pushed the fix-change-emailotp-config-to-is-alphanumeric branch from 0d39d94 to efc3e29 Compare January 17, 2024 05:52
mpmadhavig and others added 2 commits January 17, 2024 11:43
…rg/wso2/carbon/identity/governance/IdentityGovernanceServiceImpl.java

Co-authored-by: Udara Pathum <[email protected]>
@mpmadhavig mpmadhavig merged commit 61cc6ab into wso2-extensions:master Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the email OTP config name from enable numeric OTP to alphanumeric OTP
4 participants