Fix Multi Attribute Username Resolving Issue for resend-code #792
Conversation
| @@ -64,7 +68,7 @@ public Response resendCodePost(ResendCodeRequestDTO resendCodeRequestDTO) { | |||
| ResolvedUserResult resolvedUserResult = FrameworkUtils.processMultiAttributeLoginIdentification( | |||
| resendCodeRequestDTO.getUser().getUsername(), resendCodeRequestDTO.getUser().getTenantDomain()); | |||
| if (ResolvedUserResult.UserResolvedStatus.SUCCESS.equals(resolvedUserResult.getResolvedStatus())) { | |||
| resendCodeRequestDTO.getUser().setUsername(resolvedUserResult.getUser().getUsername()); | |||
| resendCodeRequestDTO.getUser().setUsername(resolvedUserResult.getUser().getPreferredUsername()); | |||
There was a problem hiding this comment.
Can u check whether password recovery[1] API also affected with the same issue
[1]
There was a problem hiding this comment.
-
There is NO issue in password recovery API since it needs the username in the format
<USER_STORE>/<USERNAME>for secondary user store users unlike in resend code. -
Tested with Primary and Secondary user store users and the flows are working as expected.
There was a problem hiding this comment.
Analysis
- For
resende-codeflow, the username is stored in the format of<USERNAME>in IDN_RECOVERY_DATA table but forpassword-recoveryflow, the username is stored in the format of<USER_STORE>/<USERNAME>(only for secondary user stores) as follows.
There was a problem hiding this comment.
As discussed offline let's create a git issue to track this inconsistencies
There was a problem hiding this comment.
|
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7284627735
Purpose
resend-codeby getting thepreferred username(which doesn't include user store name with the username) instead ofusername.Related Issues