Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Username Recovery for Domain appended Claim Values #812

Merged

Conversation

ImalshaG
Copy link
Contributor

@ImalshaG ImalshaG commented Feb 28, 2024

This PR fixes the issue in username recovery flow when the userstore domain is appended to the user claims that are being sent by a user to invoke the username-recovery API. Adding back this behaviour which was removed with the change from #623

After this fix:

  • If there is at least 1 claim having the userstore domain concatenated, that domain will be considered as the user's domain and the user account will be searched only inside that userstore.
  • If there are multiple domains attached to the claims, a client error will be thrown.
  • If there is no domain attached, the user account will be searched inside all available userstores.

Related issue: wso2/product-is#19772

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8111736458

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8111736458
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8111736458

@ImalshaG ImalshaG merged commit f8319fb into wso2-extensions:master Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants