Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle self user registration failure when the email domain is not matched with organization email domain #813

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Mar 4, 2024

Proposed changes in this pull request

  1. Enable self registration for orgs
[identity_mgt.user_self_registration]
allow_self_registration=true
lock_on_creation=true
enable_recaptcha=true
verification_email_validity="1440"
callback_url="[${carbon.protocol}://${carbon.host}:${carbon.management.port}].*[/authenticationendpoint/login.do]*"
enable_resend_confirmation_recaptcha=true

[identity_mgt.user_self_registration.notification]
manage_internally=true   
  1. Set email domain organization discovery for an organization.

  2. Try self registering with setting email as not matching email domain

Related Issues

After the fix

Screenshot 2024-10-02 at 16 45 20

@sadilchamishka
Copy link
Contributor Author

sadilchamishka commented Oct 2, 2024

Better if we can have validation logic at the portal level so that self registering with incorrect email domain can be blocked and allowed to set an allowed domain. But raising the PR as the previous server error and the display msg looks not intuitive for the end user.

PasinduYeshan
PasinduYeshan previously approved these changes Oct 2, 2024
AnuradhaSK
AnuradhaSK previously approved these changes Oct 2, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11142949997

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11142949997
Status: failure

@sadilchamishka sadilchamishka force-pushed the improve-self-registration-fail-email-domain-not-match branch from 810797c to da9ce97 Compare October 2, 2024 11:38
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11143127704

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.72%. Comparing base (5b1f2c2) to head (f299545).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
...y/recovery/signup/UserSelfRegistrationManager.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #813      +/-   ##
============================================
+ Coverage     24.21%   24.72%   +0.50%     
- Complexity      996     1012      +16     
============================================
  Files           267      267              
  Lines         15478    15492      +14     
  Branches       2094     2098       +4     
============================================
+ Hits           3748     3830      +82     
+ Misses        11256    11168      -88     
- Partials        474      494      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11143127704
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11143127704

@sadilchamishka sadilchamishka force-pushed the improve-self-registration-fail-email-domain-not-match branch from 14529e1 to 0b9ba6f Compare October 3, 2024 02:33
@sadilchamishka sadilchamishka force-pushed the improve-self-registration-fail-email-domain-not-match branch from 2fcf101 to f299545 Compare October 3, 2024 09:01
@sadilchamishka sadilchamishka merged commit 6728960 into wso2-extensions:master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants