Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring Removal] Modify web.xml in recovery and user endpoints #883

Conversation

lashinijay
Copy link
Contributor

@lashinijay lashinijay commented Nov 26, 2024

Purpose

This PR modifies web.xml in user and recovery endpoint to remove spring dependencies.

Related Issue(s)

Reference PR

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (2630019) to head (1e1c8b0).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
+ Coverage     50.45%   50.76%   +0.31%     
+ Complexity     2380     2378       -2     
============================================
  Files           297      297              
  Lines         17770    17901     +131     
  Branches       2517     2561      +44     
============================================
+ Hits           8965     9088     +123     
- Misses         7665     7671       +6     
- Partials       1140     1142       +2     
Flag Coverage Δ
unit 38.37% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lashinijay lashinijay force-pushed the feature-remove-spring-endpoints branch from 9f4e43d to 1e1c8b0 Compare November 26, 2024 08:58
@lashinijay
Copy link
Contributor Author

Closing as it was decided to remove the component since it is unified with the api webapp.

#888

@lashinijay lashinijay closed this Dec 5, 2024
@lashinijay lashinijay reopened this Dec 5, 2024
@lashinijay lashinijay closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant