Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification Template Retrieval Methods with Resolve Param Support #887

Merged

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Dec 4, 2024

Purpose

  • The following methods are added to NotificationTemplateManager.
    • getAllNotificationTemplates(String, String, boolean)
    • getNotificationTemplatesOfType(String, String, String, String, boolean)
    • getNotificationTemplate(String, String, String, String, String, boolean)

Related Issues

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (35e8681) to head (9588b8d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #887      +/-   ##
============================================
+ Coverage     50.32%   50.35%   +0.02%     
+ Complexity     2385     2358      -27     
============================================
  Files           297      297              
  Lines         17899    17907       +8     
  Branches       2558     2559       +1     
============================================
+ Hits           9008     9017       +9     
- Misses         7747     7750       +3     
+ Partials       1144     1140       -4     
Flag Coverage Δ
unit 37.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnuradhaSK
AnuradhaSK previously approved these changes Dec 5, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12195509682

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12195509682
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12195509682

@dhaura dhaura merged commit f91d8df into wso2-extensions:master Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants