Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip setting the verified claim for notification less password recovery flows #891

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

shanggeeth
Copy link
Contributor

Purpose

  • We need to skip setting the emailVerfied claim when the recovery flows goes through a notification less recovery flow.

Related Issue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12346731116

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.66%. Comparing base (f244f5c) to head (becd0fa).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
.../password/NotificationPasswordRecoveryManager.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     50.61%   50.66%   +0.05%     
+ Complexity     2462     2412      -50     
============================================
  Files           298      298              
  Lines         18142    18123      -19     
  Branches       2573     2574       +1     
============================================
  Hits           9182     9182              
+ Misses         7808     7790      -18     
+ Partials       1152     1151       -1     
Flag Coverage Δ
unit 38.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12346731116
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12346731116

@shanggeeth shanggeeth merged commit 3dafa8d into wso2-extensions:master Dec 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants