Redirect to callback URL during error scenarios according to the response type #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasundharmadasa
requested review from
aaujayasena,
Buddhimah,
denuwanthi,
dewniMW,
emswbandara,
janakamarasena and
mefarazath
as code owners
mefarazath
reviewed
Sep 10, 2020
| return Boolean.parseBoolean(IdentityUtil.getProperty(ALLOW_ADDITIONAL_PARAMS_FROM_ERROR_URL)); | ||
| String isAllowAdditionalParamsEnabled = IdentityUtil.getProperty(ALLOW_ADDITIONAL_PARAMS_FROM_ERROR_URL); | ||
|
|
||
| if (StringUtils.isNotBlank(isAllowAdditionalParamsEnabled)) { |
There was a problem hiding this comment.
Shouldn't this be the other way in the master?
ie. by default we should not allow additional params in the error URL as it violates the spec
There was a problem hiding this comment.
Made isAllowAdditionalParamsEnabled be false by default. Thank you for pointing that out.
mefarazath
approved these changes
Sep 11, 2020
jenkins-is-staging
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Approving the pull request based on the successful Jenkins job https://jenkins-support-all.wso2.com/jenkins/job/DEV_PR_BUILDER/731/, started by ,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front porting the fix from the PR https://github.com/wso2-support/identity-inbound-auth-oauth/pull/631 into master
Related Issues
wso2/product-is#5277 (Code fixed for the PR: #617)
wso2/product-is#7673