Preserve already existing query params in callback url when fragment response mode is used. #2158
Conversation
|
PR builder started |
| String.join("&", queryParams)); | ||
|
|
||
| redirectUrl = redirectUrl.replace("?", "#"); | ||
| redirectUrl += "#" + String.join("&", queryParams); |
There was a problem hiding this comment.
Need to add unit tests & change the queryParams name to params
There was a problem hiding this comment.
Fixed with later commits.
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6259167324
|
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6432401485
Callback url can have query params in it. Currently when fragment response mode is used, those query params are also being sent as fragments. Ideally the existing query params should be there in the redirect url as query params eventhough the response mode is fragment. This PR fixes this issue wso2/product-is#16668
This PR also removes code duplication in OAuth2AuthzEndpointTest unit tests introduced by #2037.