Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore claims outside request object #2160

Merged
merged 14 commits into from
Oct 10, 2023
Merged

Ignore claims outside request object #2160

merged 14 commits into from
Oct 10, 2023

Conversation

RivinduM
Copy link
Contributor

@RivinduM RivinduM commented Sep 8, 2023 •
edited
Loading

Proposed changes in this pull request

According to the FAPI specification, the claims outside the request object needs to be ignored.1
This pr mandates the request object for FAPI flows and ignores the parameters sent outside the request object

[1] https://openid.net/specs/openid-financial-api-part-2-1_0.html#authorization-server

Related Issues

wso2/product-is#16621

@RivinduM
Copy link
Contributor Author

Unit tests needs to be added after merging #2156

@RivinduM
Fix review comments
ba5de36
@RivinduM
Merge remote-tracking branch 'upstream/master' into ignoreClaims
356b436 
# Conflicts:
#	components/org.wso2.carbon.identity.oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java
@RivinduM
Fix review comments
91e786f
@RivinduM
Improve unit tests
e6a16ed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6433763389

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6433763389
Status: failure

@janakamarasena
Copy link
Contributor

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/6433763389 Status: failure

@ChinthakaJ98 Applying the diff has failed. This is most probably because the branch is outdated. Take a pull from the origin and update the branch.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6452477052

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6452477052
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6465609565

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6465609565
Status: failure

@janakamarasena
Copy link
Contributor

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/6465609565 Status: failure

This is failing as the builder is unable to apply the diff for the keystone in the unit test. Let's merge this PR and run the tests against the dependency bump.

error: components/org.wso2.carbon.identity.oauth.endpoint/src/test/resources/repository/resources/security/testkeystore.jks: patch does not apply

@janakamarasena janakamarasena merged commit 86da3ac into wso2-extensions:master Oct 10, 2023
1 check passed
@janakamarasena
Copy link
Contributor

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/6465609565 Status: failure

This is failing as the builder is unable to apply the diff for the keystone in the unit test. Let's merge this PR and run the tests against the dependency bump.

error: components/org.wso2.carbon.identity.oauth.endpoint/src/test/resources/repository/resources/security/testkeystore.jks: patch does not apply

PR builder passed for dependency update wso2/product-is#16904 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinthakaJ98 ChinthakaJ98 ChinthakaJ98 left review comments

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RivinduM @jenkins-is-staging @janakamarasena @ChinthakaJ98