Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional OAuth attributes in DCR #2173

Merged
merged 27 commits into from
Oct 16, 2023
Merged

Add support for additional OAuth attributes in DCR #2173

merged 27 commits into from
Oct 16, 2023

Conversation

SachiniSiriwardene
Copy link
Contributor

@SachiniSiriwardene SachiniSiriwardene commented Sep 26, 2023 •
edited
Loading

Proposed changes in this pull request

Add support for storing, retrieving and updating additional OIDC attributes via DCR API.

  • token_endpoint_auth_method
  • token_endpoint_auth_signing_alg
  • sector_identifier_uri
  • id_token_signed_response_alg
  • id_token_encrypted_response_alg
  • id_token_encrypted_response_enc
  • request_object_signing_alg
  • software_statement
  • tls_client_auth_subject_dn
  • require_signed_request_object
  • require_pushed_authorization_requests
  • tls_client_certificate_bound_access_tokens
  • subject_type
  • request_object_encryption_alg
  • request_object_encryption_enc

wso2/product-is#16828

Integration test PR - wso2/product-is#16953

When should this PR be merged

[Please describe any preconditions that need to be addressed before we
can merge this pull request.]

Follow up actions

[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly?

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

ChinthakaJ98
ChinthakaJ98 reviewed Sep 27, 2023
View reviewed changes
...wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java Outdated
@@ -669,6 +683,75 @@ private void addOrUpdateOIDCSpProperty(OAuthAppDO oauthAppDO,
TOKEN_BINDING_VALIDATION, String.valueOf(oauthAppDO.isTokenBindingValidationEnabled()),
prepStatementForPropertyAdd, preparedStatementForPropertyUpdate);

addOrUpdateOIDCSpProperty(preprocessedClientId, spTenantId, spOIDCProperties,
TOKEN_AUTH_METHOD, String.valueOf(oauthAppDO.getTokenEndpointAuthMethod()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these getters used are returning String values, cant we straight away get the value from the getters without passing it to String.valueOf() method. Please check the other places as well in the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with 09b4239

...cr/src/gen/java/org/wso2/carbon/identity/oauth2/dcr/endpoint/dto/RegistrationRequestDTO.java Outdated Show resolved Hide resolved
@SachiniSiriwardene SachiniSiriwardene marked this pull request as ready for review October 3, 2023 04:49
@SachiniSiriwardene
Merge branch 'master' of https://github.com/wso2-extensions/identity-…
a6471e0 
…inbound-auth-oauth into master_DCR_New_Approach

� Conflicts:
�	components/org.wso2.carbon.identity.oauth.common/src/main/java/org/wso2/carbon/identity/oauth/common/OAuthConstants.java
@SachiniSiriwardene
resolve merge conflicts
09663af
@SachiniSiriwardene SachiniSiriwardene mentioned this pull request Oct 14, 2023
Closed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6529567996

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6529567996
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 16, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6529567996

@janakamarasena janakamarasena merged commit 395df46 into wso2-extensions:master Oct 16, 2023
1 check passed
@SachiniSiriwardene SachiniSiriwardene mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SujanSanjula96 SujanSanjula96 SujanSanjula96 left review comments

@ChinthakaJ98 ChinthakaJ98 ChinthakaJ98 left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SachiniSiriwardene @jenkins-is-staging @janakamarasena @ChinthakaJ98 @SujanSanjula96