Update oauth endpoint request with t, ut and sp #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamathns
reviewed
Oct 2, 2023
| @@ -235,6 +235,9 @@ public class OAuth2AuthzEndpoint { | |||
|
|
|||
| private static final String PARAMETERS = "params"; | |||
| private static final String FORM_POST_REDIRECT_URI = "redirectURI"; | |||
| private static final String SERVICE_PROVIDER = "s"; | |||
There was a problem hiding this comment.
since these are processed again in the oauth_response file, shall we add descriptive param names?
eg: serviceProvider, userTenantDomain, TenantDomain, etc
There was a problem hiding this comment.
This was resolved with commit 15b53ca
chamathns
reviewed
Oct 4, 2023
...ndpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chamath Samarawickrama <[email protected]>
chamathns
approved these changes
Oct 4, 2023
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6402097663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This updates the oath endpoint request with tenant domain(t), user tenant domain (ut) and service provider (sp) in order to facilitate the execution of branding API.
Related Issues