Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring Cleanup] Remove spring dependencies in DCR endpoint #2627

Closed

Conversation

lashinijay
Copy link
Contributor

Purpose

This PR removes dependencies and usages of the Spring framework in the DCR REST API.

Related Issue(s)

@lashinijay lashinijay force-pushed the feature-remove-spring-dcr branch from a4f282c to 4d534df Compare November 19, 2024 07:51
@lashinijay lashinijay force-pushed the feature-remove-spring-dcr branch from 8076900 to 3695624 Compare November 19, 2024 08:05
@lashinijay lashinijay force-pushed the feature-remove-spring-dcr branch from 32258a2 to d5062fb Compare November 19, 2024 11:10
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.25%. Comparing base (dc41ff9) to head (d5062fb).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
.../endpoint/factories/RegisterApiServiceFactory.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2627      +/-   ##
============================================
+ Coverage     53.35%   55.25%   +1.90%     
+ Complexity     8589     8199     -390     
============================================
  Files           632      631       -1     
  Lines         52956    47471    -5485     
  Branches       9069     8375     -694     
============================================
- Hits          28253    26232    -2021     
+ Misses        20597    17491    -3106     
+ Partials       4106     3748     -358     
Flag Coverage Δ
unit 38.66% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lashinijay
Copy link
Contributor Author

Duplicate of #2631

@lashinijay lashinijay marked this as a duplicate of #2631 Nov 20, 2024
@lashinijay lashinijay closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant