-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property "renew_token_without_revoking_existing" not being honored causing stuck threads #2630
Property "renew_token_without_revoking_existing" not being honored causing stuck threads #2630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2630 +/- ##
============================================
+ Coverage 55.76% 55.77% +0.01%
+ Complexity 8239 8194 -45
============================================
Files 632 632
Lines 47478 47502 +24
Branches 8385 8392 +7
============================================
+ Hits 26477 26496 +19
Misses 17211 17211
- Partials 3790 3795 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
5f067e1
to
eaba6be
Compare
...bon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/OauthTokenIssuer.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/OAuth2Constants.java
Outdated
Show resolved
Hide resolved
.../org/wso2/carbon/identity/oauth2/token/handlers/grant/AbstractAuthorizationGrantHandler.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11966760205
Proposed changes in this pull request
This PR addresses issues related to token renewal and token type handling to enhance the stability and configurability of the token issuance process. When the
renew_without_revoking_existing
flag is enabled and the binding type is set to "none," the implementation now skips checking for existing tokens. Instead, it generates a random UUID as the binding reference, which helps to prevent thread-stuck issues in high-concurrency scenarios.A new approach is introduced for retrieving the token type from custom token issuers. The OauthTokenIssuer interface now includes a default method,
getAccessTokenType()
, which returns "Opaque" by default. In the JWTTokenIssuer class, this method is overridden to return "JWT." This allows the system to correctly identify the token type without requiring additional configurations, making the implementation more flexible and easier to extend.Related Issues
Follow up actions
Update the migration documentation to reflect the changes in token type handling. Specifically, note that a previously used Deployment.toml configuration for specifying the token type is no longer required, and custom JWT issuers that do not extend the
JWTTokenIssuer
class must override the getter method to specify the token type explicitly. Similarly, if implementing the OauthTokenIssuer interface, the method must be overridden to ensure compatibility.