Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary DB queries when revoking tokens #2640

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SujanSanjula96
Copy link
Contributor

Proposed changes in this pull request

From this PR,

  • Fixed unnecessary DB queries due to invoking getRoles method.
  • Removed the usage of getting associated applications since it is unnecessary.
  • Refactored unnecessary iterations related to associated applications.

Issue - wso2/product-is#21496

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.48%. Comparing base (654bc26) to head (c14d5ef).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
...java/org/wso2/carbon/identity/oauth/OAuthUtil.java 62.50% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2640      +/-   ##
============================================
- Coverage     56.44%   55.48%   -0.96%     
- Complexity     8193     8536     +343     
============================================
  Files           632      632              
  Lines         46331    49870    +3539     
  Branches       8246     9295    +1049     
============================================
+ Hits          26151    27672    +1521     
- Misses        16465    18254    +1789     
- Partials       3715     3944     +229     
Flag Coverage Δ
unit 38.95% <62.50%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12365957250

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12365957250
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12573369808

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12573369808
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12573390275

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12573390275
Status: failure

@SujanSanjula96 SujanSanjula96 force-pushed the role-v2-patch-token-revocation branch from d19b35b to 74b2650 Compare January 2, 2025 18:57
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12595281635

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12595794304

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12595281635
Status: cancelled

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12595794304
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12595794304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants