Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for device code grant request #2658

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kayathiri4
Copy link
Contributor

Proposed changes in this pull request

Fixes https://github.com/wso2-enterprise/wso2-iam-internal/issues/2866

We are adding the wrapper to prevent missing of body parameters in the request. We follow the sam approach we used previously to fix similar issues:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12594605490

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.43%. Comparing base (9095d8d) to head (c5d5091).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2658      +/-   ##
============================================
+ Coverage     56.40%   56.43%   +0.02%     
+ Complexity     8269     8259      -10     
============================================
  Files           632      632              
  Lines         46680    46681       +1     
  Branches       8508     8508              
============================================
+ Hits          26332    26346      +14     
+ Misses        16585    16573      -12     
+ Partials       3763     3762       -1     
Flag Coverage Δ
unit 38.75% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12594605490
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12594605490

@kayathiri4 kayathiri4 merged commit 71fa07f into wso2-extensions:master Jan 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants